Re: [libvirt] [PATCH v2 1/2] storage: Don't update volume objs list before we successfully create one

2015-06-02 Thread Martin Kletzander
On Mon, Jun 01, 2015 at 03:14:24PM +0200, Martin Kletzander wrote: On Thu, May 28, 2015 at 05:29:54PM +0200, Erik Skultety wrote: We do update pool volume object list before we actually create any volume. If buildVol fails, we then try to delete the volume in the storage as well as remove it

Re: [libvirt] [PATCH v2 1/2] storage: Don't update volume objs list before we successfully create one

2015-06-01 Thread Martin Kletzander
On Thu, May 28, 2015 at 05:29:54PM +0200, Erik Skultety wrote: We do update pool volume object list before we actually create any volume. If buildVol fails, we then try to delete the volume in the storage as well as remove it from our structures. The problem is, that any backend that supports

[libvirt] [PATCH v2 1/2] storage: Don't update volume objs list before we successfully create one

2015-05-28 Thread Erik Skultety
We do update pool volume object list before we actually create any volume. If buildVol fails, we then try to delete the volume in the storage as well as remove it from our structures. The problem is, that any backend that supports both buildVol and deleteVol would fail in this case which is