Re: [libvirt] [PATCH v2 1/2] util: Add helper APIs to get/verify VF Representor name

2018-02-21 Thread Jai Singh Rana
Thanks John for a very detailed review and feedback for this patch set. As this is my first patch submission to libvirt, I was really looking for the review from the community and this review is really helpful and informing. I agree with concerns and suggestions highlighted and will prepare v3 to

Re: [libvirt] [PATCH v2 1/2] util: Add helper APIs to get/verify VF Representor name

2018-02-20 Thread John Ferlan
On 02/12/2018 03:07 AM, Jai Singh Rana wrote: > Switchdev VF Representor interface name on host is derived based on BDF > of pci SR-IOV device in 'hostdev' and querying required net sysfs > entries on host. Really short for what's being added here. Not sure what BDF is... s/pci/PCI Essentiall

[libvirt] [PATCH v2 1/2] util: Add helper APIs to get/verify VF Representor name

2018-02-12 Thread Jai Singh Rana
Switchdev VF Representor interface name on host is derived based on BDF of pci SR-IOV device in 'hostdev' and querying required net sysfs entries on host. --- v2 includes commented code cleanup in virnetdevhostdev.c po/POTFILES.in | 1 + src/Makefile.am | 1 + src/lib