On Tue, May 17, 2016 at 08:03:11AM -0400, Cole Robinson wrote:
> On 05/17/2016 06:11 AM, Christophe Fergeau wrote:
> > Hey,
> >
> > After this patch series, the QEMU command line may not contain port nor
> > tls-port if they both were set to '0'. However, QEMU versions older than
> > 2.3.0 will
On Tue, May 17, 2016 at 02:10:16PM +0200, Ján Tomko wrote:
> On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > After this patch series, the QEMU command line may not contain port nor
> > tls-port if they both were set to '0'. However, QEMU versions older than
>
On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote:
> Hey,
>
> After this patch series, the QEMU command line may not contain port nor
> tls-port if they both were set to '0'. However, QEMU versions older than
> 2.3.0 will error out because they don't have this commit:
>
On 05/17/2016 06:11 AM, Christophe Fergeau wrote:
> Hey,
>
> After this patch series, the QEMU command line may not contain port nor
> tls-port if they both were set to '0'. However, QEMU versions older than
> 2.3.0 will error out because they don't have this commit:
>
Hey,
After this patch series, the QEMU command line may not contain port nor
tls-port if they both were set to '0'. However, QEMU versions older than
2.3.0 will error out because they don't have this commit:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cf7856adefebe86e0
I assume we want to
On Fri, Mar 18, 2016 at 11:09:25AM +0100, Christophe Fergeau wrote:
> On Fri, Mar 18, 2016 at 10:25:58AM +0100, Ján Tomko wrote:
> > This breaks make syntax-check:
> >
> > Curly brackets around single-line body:
> > src/qemu/qemu_command.c:7559-7561:
> > if (graphics->data.spice.copypaste ==
The end goal is to avoid adding -spice port=0,addr=127.0.0.1 to QEMU command
line when no SPICE port is specified in libvirt XML.
Currently, the code relies on port=xx to always be present, so subsequent
args can be unconditionally appended with a leading ','. Since port=0
will no longer be added
On Wed, Mar 16, 2016 at 05:45:03PM +0100, Christophe Fergeau wrote:
> The end goal is to avoid adding -spice port=0,addr=127.0.0.1 to QEMU command
> line when no SPICE port is specified in libvirt XML.
>
> Currently, the code relies on port=xx to always be present, so subsequent
> args can be
On Fri, Mar 18, 2016 at 10:25:58AM +0100, Ján Tomko wrote:
> > -if (graphics->data.spice.playback)
> > -virBufferAsprintf(, ",playback-compression=%s",
> > +}
> > +if (graphics->data.spice.playback) {
> > +virBufferAsprintf(, "playback-compression=%s,",
> >
