Re: [libvirt] [PATCH v2 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-31 Thread Daniel P. Berrange
On Tue, Jan 31, 2012 at 01:49:11PM +0900, Taku Izumi wrote: @@ -3156,6 +3159,26 @@ virDomainDiskDefParseXML(virCapsPtr caps def-snapshot = VIR_DOMAIN_DISK_SNAPSHOT_NO; } +def-rawio = -1; /* unspecified */ +if (rawio) { +if (def-device ==

Re: [libvirt] [PATCH v2 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-31 Thread Laine Stump
On 01/31/2012 07:03 AM, Daniel P. Berrange wrote: On Tue, Jan 31, 2012 at 01:49:11PM +0900, Taku Izumi wrote: @@ -3156,6 +3159,26 @@ virDomainDiskDefParseXML(virCapsPtr caps def-snapshot = VIR_DOMAIN_DISK_SNAPSHOT_NO; } +def-rawio = -1; /* unspecified */ +if (rawio) { +

Re: [libvirt] [PATCH v2 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-31 Thread Eric Blake
On 01/31/2012 11:53 AM, Laine Stump wrote: I also found that make check wouldn't pass, which was mostly traced to the concept of making the default value of rawio -1. The problem with this is that there are other functions that create and fill-in domain structures, and they hadn't been taught

[libvirt] [PATCH v2 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Taku Izumi
This patch adds a new attribute rawio to the disk element of domain XML. Valid values of rawio attribute are yes and no. rawio='yes' indicates the disk is desirous of CAP_SYS_RAWIO. If you specify the following XML: disk type='block' device='lun' rawio='yes' ... /disk the domain