Re: [libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-10-05 Thread Eric Farman
On 09/13/2016 05:48 PM, Eric Farman wrote: On 09/13/2016 04:49 PM, John Ferlan wrote: [...] Thanks for the review. (Silent ACK on a lot of the above comments.) I'll try to get these all in place for a v3 with a little runway before the next freeze. OK - hopefully I won't be neck deep

Re: [libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-09-13 Thread Eric Farman
On 09/13/2016 04:49 PM, John Ferlan wrote: [...] I took a peek at the v1, but suffice to say didn't follow it that closely since there's a number of changes in v2 related to patch ordering. You could get 3 different opinions on that matter too! Hopefully a consensus before too long. :)

Re: [libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-09-13 Thread John Ferlan
[...] >>> >> I took a peek at the v1, but suffice to say didn't follow it that >> closely since there's a number of changes in v2 related to patch >> ordering. You could get 3 different opinions on that matter too! > > Hopefully a consensus before too long. :) > yeah - v1 was lots of little

Re: [libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-09-13 Thread Eric Farman
On 09/12/2016 05:34 PM, John Ferlan wrote: On 09/06/2016 08:58 AM, Eric Farman wrote: We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the

Re: [libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-09-12 Thread John Ferlan
On 09/06/2016 08:58 AM, Eric Farman wrote: > We already have a "scsi" hostdev type, which refers to a single LUN > that is passed through to a guest. But what of things where multiple > LUNs are passed through via a single SCSI HBA, such as with the > vhost-scsi target? Create a new hostdev

[libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-09-06 Thread Eric Farman
We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the vhost-scsi target? Create a new hostdev type that will carry this, and its associated

[libvirt] [PATCH v2 1/5] Introduce a "scsi_host" hostdev type

2016-08-20 Thread Eric Farman
We already have a "scsi" hostdev type, which refers to a single LUN that is passed through to a guest. But what of things where multiple LUNs are passed through via a single SCSI HBA, such as with the vhost-scsi target? Create a new hostdev type that will carry this, and its associated