Re: [libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-10-22 Thread Daniel P . Berrangé
On Wed, Sep 11, 2019 at 05:16:31PM +0200, Michal Privoznik wrote: > On 9/11/19 3:24 PM, Daniel P. Berrangé wrote: > > On Wed, Sep 11, 2019 at 03:17:42PM +0200, Michal Privoznik wrote: > >> In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() > >> function which returns true or false if given

Re: [libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Michal Privoznik
On 9/11/19 3:24 PM, Daniel P. Berrangé wrote: > On Wed, Sep 11, 2019 at 03:17:42PM +0200, Michal Privoznik wrote: >> In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() >> function which returns true or false if given drive address is >> already in use for given domain config or not.

Re: [libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Daniel P . Berrangé
On Wed, Sep 11, 2019 at 03:17:42PM +0200, Michal Privoznik wrote: > In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() > function which returns true or false if given drive address is > already in use for given domain config or not. However, it also > takes a shortcut and returns true

[libvirt] [PATCH v2 2/2] domain_conf: Relax SCSI addr used check

2019-09-11 Thread Michal Privoznik
In domain_conf.c we have virDomainSCSIDriveAddressIsUsed() function which returns true or false if given drive address is already in use for given domain config or not. However, it also takes a shortcut and returns true (meaning address in use) if the unit number equals 7. This is because for some