Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-13 Thread Laine Stump
On 06/13/2018 09:00 AM, John Ferlan wrote: > > On 06/13/2018 08:36 AM, Ján Tomko wrote: >> On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote: Or we could focus our energy elsehwere. >>> I like this option...  Fix the one offs when/if they show up and move >>> on. If someone, som

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-13 Thread John Ferlan
On 06/13/2018 08:36 AM, Ján Tomko wrote: > On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote: >>> >>> Or we could focus our energy elsehwere. >>> >> >> I like this option...  Fix the one offs when/if they show up and move >> on. If someone, some day has the desire to write patches that

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-13 Thread Ján Tomko
On Wed, Jun 13, 2018 at 08:26:40AM -0400, John Ferlan wrote: Or we could focus our energy elsehwere. I like this option... Fix the one offs when/if they show up and move on. If someone, some day has the desire to write patches that will revamp device address assignment, good luck! I meant

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-13 Thread John Ferlan
On 06/13/2018 07:15 AM, Ján Tomko wrote: > On Tue, Jun 12, 2018 at 06:06:02PM -0400, Laine Stump wrote: >> On 06/12/2018 10:32 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1559867 >>> >>> When attaching a device to the domain we need to be sure >>> to use the correct do

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-13 Thread Ján Tomko
On Tue, Jun 12, 2018 at 06:06:02PM -0400, Laine Stump wrote: On 06/12/2018 10:32 AM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1559867 When attaching a device to the domain we need to be sure to use the correct domain definition (vm->def or vm->newDef) when calling virDomai

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-12 Thread John Ferlan
On 06/12/2018 06:06 PM, Laine Stump wrote: > On 06/12/2018 10:32 AM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1559867 >> >> When attaching a device to the domain we need to be sure >> to use the correct domain definition (vm->def or vm->newDef) >> when calling virDomainD

Re: [libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-12 Thread Laine Stump
On 06/12/2018 10:32 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1559867 > > When attaching a device to the domain we need to be sure > to use the correct domain definition (vm->def or vm->newDef) > when calling virDomainDeviceDefParse because the post parse > processing alg

[libvirt] [PATCH v2 2/2] qemu: Use the correct vm def on cold attach

2018-06-12 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1559867 When attaching a device to the domain we need to be sure to use the correct domain definition (vm->def or vm->newDef) when calling virDomainDeviceDefParse because the post parse processing algorithms that may assign an address for the device will