Re: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-29 Thread Erik Skultety
> > > the "+ i" also seems unnecessary. > > I just added it in order for different CPUs to return different values. > +1, +2 etc. are trivial quantities so the results still make sense imo Well, I didn't see a use case in that, but someone may sort the returned stats by the most utilized CPU, so

Re: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-29 Thread Ilias Stamatis
On Mon, Jul 29, 2019 at 3:28 PM Erik Skultety wrote: > > On Sun, Jul 28, 2019 at 12:02:21PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 132 + > > 1 file changed, 132 insertions(+) > > > > diff --git

Re: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-29 Thread Erik Skultety
On Sun, Jul 28, 2019 at 12:02:21PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 132 + > 1 file changed, 132 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 132 + 1 file changed, 132 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ab0f8b06d6..56f08fc3d2 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c