Re: [libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-27 Thread Andrea Bolognani
On Wed, 2015-05-27 at 16:47 +0200, Michal Privoznik wrote: > > -bool config = vshCommandOptBool(cmd, "config"); > > +bool config = vshCommandOptBool(ctl, cmd, "config"); > > I don't think this is needed. vshCommandOptBool should never return an > error. Well, it's returning just if a flag

Re: [libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-27 Thread Michal Privoznik
On 22.05.2015 10:59, Andrea Bolognani wrote: > This will allow us to use vshError() to report errors from inside > vshCommandOpt*(), instead of replicating the same logic and error > messages all over the place. > > We also have more context inside the vshCommandOpt*() functions, > for example the

[libvirt] [PATCH v2 2/3] virsh: Pass vshControl to all vshCommandOpt*() calls.

2015-05-22 Thread Andrea Bolognani
This will allow us to use vshError() to report errors from inside vshCommandOpt*(), instead of replicating the same logic and error messages all over the place. We also have more context inside the vshCommandOpt*() functions, for example the actual value used on the command line, which means we ca