Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-15 Thread Osier Yang
On 10/07/13 22:49, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for chap types. Continue to allow login for backwards compatibility when

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-15 Thread Osier Yang
On 11/07/13 00:04, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 11:51:42AM -0400, John Ferlan wrote: On 07/10/2013 10:49 AM, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: To be consistent with ceph types for storage auth elements, allow username

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-11 Thread John Ferlan
On 07/10/2013 12:04 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 11:51:42AM -0400, John Ferlan wrote: On 07/10/2013 10:49 AM, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: ...snip To be sure we're on the same page, the storage_conf XML then

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-11 Thread Daniel P. Berrange
On Thu, Jul 11, 2013 at 10:11:16AM -0400, John Ferlan wrote: On 07/10/2013 12:04 PM, Daniel P. Berrange wrote: On Wed, Jul 10, 2013 at 11:51:42AM -0400, John Ferlan wrote: On 07/10/2013 10:49 AM, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: ...snip

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-10 Thread Daniel P. Berrange
On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for chap types. Continue to allow login for backwards compatibility when reading the XML, but when writing the XML use

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-10 Thread John Ferlan
On 07/10/2013 10:49 AM, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for chap types. Continue to allow login for backwards compatibility

Re: [libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-10 Thread Daniel P. Berrange
On Wed, Jul 10, 2013 at 11:51:42AM -0400, John Ferlan wrote: On 07/10/2013 10:49 AM, Daniel P. Berrange wrote: On Tue, Jul 09, 2013 at 03:10:46PM -0400, John Ferlan wrote: To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for

[libvirt] [PATCH v2 2/7] storage: Support username for chap type auth

2013-07-09 Thread John Ferlan
To be consistent with ceph types for storage auth elements, allow username to be used as an auth attribute name for chap types. Continue to allow login for backwards compatibility when reading the XML, but when writing the XML use username. --- docs/schemas/storagepool.rng |