Re: [libvirt] [PATCH v2 4/7] qemu: driver: Remove misplaced qemuDomainObjEndJob in qemuDomainCheckpointGetXMLDesc

2019-09-26 Thread Eric Blake

On 9/25/19 7:54 AM, Peter Krempa wrote:

The code that gets the job to refresh disk sizes was not merged yet so
remove this artifact.

Signed-off-by: Peter Krempa 
---
  src/qemu/qemu_driver.c | 3 ---
  1 file changed, 3 deletions(-)


Reviewed-by: Eric Blake 



diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ca25814bd1..7da6dbce66 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17535,9 +17535,6 @@ qemuDomainCheckpointGetXMLDesc(virDomainCheckpointPtr 
checkpoint,
  xml = virDomainCheckpointDefFormat(chkdef, driver->caps, driver->xmlopt,
 format_flags);

-if (flags & VIR_DOMAIN_CHECKPOINT_XML_SIZE)
-qemuDomainObjEndJob(driver, vm);
-
   cleanup:
  virDomainObjEndAPI();
  return xml;



--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH v2 4/7] qemu: driver: Remove misplaced qemuDomainObjEndJob in qemuDomainCheckpointGetXMLDesc

2019-09-25 Thread Peter Krempa
The code that gets the job to refresh disk sizes was not merged yet so
remove this artifact.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ca25814bd1..7da6dbce66 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17535,9 +17535,6 @@ qemuDomainCheckpointGetXMLDesc(virDomainCheckpointPtr 
checkpoint,
 xml = virDomainCheckpointDefFormat(chkdef, driver->caps, driver->xmlopt,
format_flags);

-if (flags & VIR_DOMAIN_CHECKPOINT_XML_SIZE)
-qemuDomainObjEndJob(driver, vm);
-
  cleanup:
 virDomainObjEndAPI();
 return xml;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list