Re: [libvirt] [PATCH v2 40/73] qemu: Call qemuMigrationAnyCompressionParse only from driver

[Ján Tomko]

On Wed, Apr 11, 2018 at 04:41:30PM +0200, Jiri Denemark wrote:

Propagate the calls up the stack to the point where
qemuMigrationParamsFromFlags is called. The end goal achieved in the
following few patches is to merge compression parameters into the
general migration parameters code.

Signed-off-by: Jiri Denemark 
---
src/qemu/qemu_driver.c| 21 ++---
src/qemu/qemu_migration.c | 25 +++--
src/qemu/qemu_migration.h |  1 +
3 files changed, 26 insertions(+), 21 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 40/73] qemu: Call qemuMigrationAnyCompressionParse only from driver

[Jiri Denemark]

Propagate the calls up the stack to the point where
qemuMigrationParamsFromFlags is called. The end goal achieved in the
following few patches is to merge compression parameters into the
general migration parameters code.

Signed-off-by: Jiri Denemark 
---
 src/qemu/qemu_driver.c| 21 ++---
 src/qemu/qemu_migration.c | 25 +++--
 src/qemu/qemu_migration.h |  1 +
 3 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5271e01d92..85755257aa 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -12126,6 +12126,7 @@ qemuDomainMigratePrepareTunnel(virConnectPtr dconn,
 virQEMUDriverPtr driver = dconn->privateData;
 virDomainDefPtr def = NULL;
 char *origname = NULL;
+qemuMigrationCompressionPtr compression = NULL;
 qemuMigrationParamsPtr migParams = NULL;
 int ret = -1;
 
@@ -12137,6 +12138,9 @@ qemuDomainMigratePrepareTunnel(virConnectPtr dconn,
 goto cleanup;
 }
 
+if (!(compression = qemuMigrationAnyCompressionParse(NULL, 0, flags)))
+goto cleanup;
+
 if (!(migParams = qemuMigrationParamsFromFlags(NULL, 0, flags,

QEMU_MIGRATION_DESTINATION)))
 goto cleanup;
@@ -12156,9 +12160,10 @@ qemuDomainMigratePrepareTunnel(virConnectPtr dconn,
 
 ret = qemuMigrationDstPrepareTunnel(driver, dconn,
 NULL, 0, NULL, NULL, /* No cookies in 
v2 */
-st, , origname, migParams, flags);
+st, , origname, compression, 
migParams, flags);
 
  cleanup:
+VIR_FREE(compression);
 qemuMigrationParamsFree(migParams);
 VIR_FREE(origname);
 virDomainDefFree(def);
@@ -12597,6 +12602,7 @@ qemuDomainMigratePrepareTunnel3(virConnectPtr dconn,
 virQEMUDriverPtr driver = dconn->privateData;
 virDomainDefPtr def = NULL;
 char *origname = NULL;
+qemuMigrationCompressionPtr compression = NULL;
 qemuMigrationParamsPtr migParams = NULL;
 int ret = -1;
 
@@ -12608,6 +12614,9 @@ qemuDomainMigratePrepareTunnel3(virConnectPtr dconn,
 goto cleanup;
 }
 
+if (!(compression = qemuMigrationAnyCompressionParse(NULL, 0, flags)))
+goto cleanup;
+
 if (!(migParams = qemuMigrationParamsFromFlags(NULL, 0, flags,

QEMU_MIGRATION_DESTINATION)))
 goto cleanup;
@@ -12621,9 +12630,10 @@ qemuDomainMigratePrepareTunnel3(virConnectPtr dconn,
 ret = qemuMigrationDstPrepareTunnel(driver, dconn,
 cookiein, cookieinlen,
 cookieout, cookieoutlen,
-st, , origname, migParams, flags);
+st, , origname, compression, 
migParams, flags);
 
  cleanup:
+VIR_FREE(compression);
 qemuMigrationParamsFree(migParams);
 VIR_FREE(origname);
 virDomainDefFree(def);
@@ -12646,6 +12656,7 @@ qemuDomainMigratePrepareTunnel3Params(virConnectPtr 
dconn,
 const char *dom_xml = NULL;
 const char *dname = NULL;
 char *origname = NULL;
+qemuMigrationCompressionPtr compression = NULL;
 qemuMigrationParamsPtr migParams = NULL;
 int ret = -1;
 
@@ -12667,6 +12678,9 @@ qemuDomainMigratePrepareTunnel3Params(virConnectPtr 
dconn,
 goto cleanup;
 }
 
+if (!(compression = qemuMigrationAnyCompressionParse(NULL, 0, flags)))
+goto cleanup;
+
 if (!(migParams = qemuMigrationParamsFromFlags(params, nparams, flags,

QEMU_MIGRATION_DESTINATION)))
 goto cleanup;
@@ -12680,9 +12694,10 @@ qemuDomainMigratePrepareTunnel3Params(virConnectPtr 
dconn,
 ret = qemuMigrationDstPrepareTunnel(driver, dconn,
 cookiein, cookieinlen,
 cookieout, cookieoutlen,
-st, , origname, migParams, flags);
+st, , origname, compression, 
migParams, flags);
 
  cleanup:
+VIR_FREE(compression);
 qemuMigrationParamsFree(migParams);
 VIR_FREE(origname);
 virDomainDefFree(def);
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index e1a29d9569..d4c5994f25 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2531,12 +2531,10 @@ qemuMigrationDstPrepareTunnel(virQEMUDriverPtr driver,
   virStreamPtr st,
   virDomainDefPtr *def,
   const char *origname,
+  qemuMigrationCompressionPtr compression,
   qemuMigrationParamsPtr migParams,
   unsigned long flags)
 {
-qemuMigrationCompressionPtr