Re: [libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 01:16:42PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > The cases when we cannot enable this optimization are: > 1) nvdimms > 2) if memAccess='shared' The specific use case for discard-data=on uses share=on, see:

Re: [libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 02:57:50PM +0200, Peter Krempa wrote: > On Tue, Apr 17, 2018 at 13:18:02 +0100, Daniel Berrange wrote: > > On Tue, Apr 17, 2018 at 01:16:42PM +0200, Michal Privoznik wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > > > > > The cases when we cannot

Re: [libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 13:18:02 +0100, Daniel Berrange wrote: > On Tue, Apr 17, 2018 at 01:16:42PM +0200, Michal Privoznik wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > > > The cases when we cannot enable this optimization are: > > 1) nvdimms > > 2) if memAccess='shared'

Re: [libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

On Tue, Apr 17, 2018 at 01:16:42PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1480668 > > The cases when we cannot enable this optimization are: > 1) nvdimms > 2) if memAccess='shared' > > Otherwise it is safe to enable it. This is basically saying that if

[libvirt] [PATCH v2 5/5] qemu: Enable memory-backend-file.discard-data whenever possible

https://bugzilla.redhat.com/show_bug.cgi?id=1480668 The cases when we cannot enable this optimization are: 1) nvdimms 2) if memAccess='shared' Otherwise it is safe to enable it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 7 +++ 1 file changed, 7