Re: [libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-14 Thread Erik Skultety
On Fri, Dec 14, 2018 at 10:35:50AM +0100, Peter Krempa wrote: > On Thu, Dec 13, 2018 at 17:02:55 +0100, Erik Skultety wrote: > > On Thu, Dec 13, 2018 at 03:48:56PM +0100, Peter Krempa wrote: > > > Simplify adding of new errors by just adding them to the array of > > > messages rather than having

Re: [libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-14 Thread Peter Krempa
On Thu, Dec 13, 2018 at 17:02:55 +0100, Erik Skultety wrote: > On Thu, Dec 13, 2018 at 03:48:56PM +0100, Peter Krempa wrote: > > Simplify adding of new errors by just adding them to the array of > > messages rather than having to add conversion code. > > > > Additionally most of the messages add

Re: [libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-13 Thread Erik Skultety
On Thu, Dec 13, 2018 at 03:48:56PM +0100, Peter Krempa wrote: > Simplify adding of new errors by just adding them to the array of > messages rather than having to add conversion code. > > Additionally most of the messages add the format string part as a suffix > so we can avoid some of the

[libvirt] [PATCH v2 9/9] util: error: Put error code messages into an array

2018-12-13 Thread Peter Krempa
Simplify adding of new errors by just adding them to the array of messages rather than having to add conversion code. Additionally most of the messages add the format string part as a suffix so we can avoid some of the duplication by using a macro which adds the suffix to the original string.