Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Andrea Bolognani
On Thu, 2018-07-26 at 12:52 +0100, Daniel P. Berrangé wrote: > On Thu, Jul 26, 2018 at 01:47:52PM +0200, Andrea Bolognani wrote: > > On Thu, 2018-07-26 at 12:22 +0100, Daniel P. Berrangé wrote: > > > From the libvirt side we must avoid any scenario where QEMU auto-adds > > > devices behind our

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Daniel P . Berrangé
On Thu, Jul 26, 2018 at 01:47:52PM +0200, Andrea Bolognani wrote: > On Thu, 2018-07-26 at 12:22 +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 26, 2018 at 07:17:03PM +0800, Yi Min Zhao wrote: > > > 在 2018/7/26 下午7:00, Andrea Bolognani 写道: > > > > From the test cases I see a zpci devices, with

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Andrea Bolognani
On Thu, 2018-07-26 at 12:22 +0100, Daniel P. Berrangé wrote: > On Thu, Jul 26, 2018 at 07:17:03PM +0800, Yi Min Zhao wrote: > > 在 2018/7/26 下午7:00, Andrea Bolognani 写道: > > > From the test cases I see a zpci devices, with its own uid and fid, > > > is created for the pci-bridge as well... Is that

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Daniel P . Berrangé
On Thu, Jul 26, 2018 at 07:17:03PM +0800, Yi Min Zhao wrote: > > > 在 2018/7/26 下午7:00, Andrea Bolognani 写道: > > > > > > > > How does the pci-bridge controller show up in the guest, if at > > > > > > > > all? > > > > > Qemu hides pci-bridge devices and just exposes pci devices to the > > > > >

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Yi Min Zhao
在 2018/7/26 下午7:00, Andrea Bolognani 写道: How does the pci-bridge controller show up in the guest, if at all? Qemu hides pci-bridge devices and just exposes pci devices to the guest. In above example, indeed, qemu will generate a pci-bridge device and it will be existing in pci topology. But

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-26 Thread Andrea Bolognani
On Thu, 2018-07-26 at 13:43 +0800, Yi Min Zhao wrote: > 在 2018/7/25 下午11:44, Andrea Bolognani 写道: > > > > > > How does the pci-bridge controller show up in the guest, if at all? > > > > > > Qemu hides pci-bridge devices and just exposes pci devices to the guest. > > > In above example, indeed,

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-25 Thread Yi Min Zhao
在 2018/7/25 下午11:44, Andrea Bolognani 写道: On Wed, 2018-07-25 at 16:34 +0800, Yi Min Zhao wrote: 在 2018/7/24 下午11:43, Andrea Bolognani 写道: More concrete questions: one of the zPCI test cases includes which

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-25 Thread Andrea Bolognani
On Wed, 2018-07-25 at 16:34 +0800, Yi Min Zhao wrote: > 在 2018/7/24 下午11:43, Andrea Bolognani 写道: > > > > More concrete questions: one of the zPCI test cases includes > > > > > > > > > > > > > > > > > > > > > > > >> > > function='0x0'/> > > > >

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-25 Thread Yi Min Zhao
在 2018/7/24 下午11:43, Andrea Bolognani 写道: On Tue, 2018-07-24 at 17:15 +0200, Boris Fiuczynski wrote: On 07/24/2018 03:41 PM, Andrea Bolognani wrote: Being compatible with the existing PCI machinery is certainly a good idea when it makes sense to do so, but I'm not quite convinced that is the

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Andrea Bolognani
On Tue, 2018-07-24 at 17:15 +0200, Boris Fiuczynski wrote: > On 07/24/2018 03:41 PM, Andrea Bolognani wrote: > > Being compatible with the existing PCI machinery is certainly a > > good idea when it makes sense to do so, but I'm not quite convinced > > that is the case here. > > From a user

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Boris Fiuczynski
On 07/24/2018 03:41 PM, Andrea Bolognani wrote: On Tue, 2018-07-24 at 11:31 +0200, Boris Fiuczynski wrote: On 07/24/2018 10:20 AM, Andrea Bolognani wrote: Assuming the above is a correct reading of the situation, it would seem the IDs are the only guest-visible part that we need to make sure

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Andrea Bolognani
On Tue, 2018-07-24 at 11:31 +0200, Boris Fiuczynski wrote: > On 07/24/2018 10:20 AM, Andrea Bolognani wrote: > > Assuming the above is a correct reading of the situation, it > > would seem the IDs are the only guest-visible part that we need > > to make sure doesn't change during the lifetime of

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Boris Fiuczynski
On 07/24/2018 10:20 AM, Andrea Bolognani wrote: On Mon, 2018-07-23 at 13:37 +0200, Ján Tomko wrote: On Tue, Jul 10, 2018 at 04:02:14PM +0800, Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Cornelia Huck
On Tue, 24 Jul 2018 10:20:48 +0200 Andrea Bolognani wrote: > Looking at both the generated QEMU command line and the qemu-devel > message linked above, I seem to understand the zpci device is > basically some sort of adapter that sits between a regular PCI > device (emulated or otherwise) and an

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-24 Thread Andrea Bolognani
On Mon, 2018-07-23 at 13:37 +0200, Ján Tomko wrote: > On Tue, Jul 10, 2018 at 04:02:14PM +0800, Yi Min Zhao wrote: > > Abstract > > > > The PCI representation in QEMU has recently been extended for S390 > > allowing configuration of zPCI attributes like uid (user-defined > > identifier)

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-23 Thread Laine Stump
On Mon, Jul 23, 2018, 2:37 PM Ján Tomko wrote: > > But I'd like to hear from some other developer who touched the PCI code > last (Laine? Andrea?) > I'm looking at this on the screen of my phone as I stare out the hotel window at an afternoon rainstorm over Razgrad, Bulgaria, and won't be back

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-23 Thread Ján Tomko
On Tue, Jul 10, 2018 at 04:02:14PM +0800, Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier). The details can be found here:

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-22 Thread Yi Min Zhao
Hi all, The next release is coming soon. I'm really expecting the comments from all of you. Hope you could consider a review before the next review. Thank you very much! Yi Min 在 2018/7/10 下午4:02, Yi Min Zhao 写道: Abstract The PCI representation in QEMU has recently been extended

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-18 Thread Yi Min Zhao
在 2018/7/17 下午8:35, Cornelia Huck 写道: On Tue, 10 Jul 2018 16:02:14 +0800 Yi Min Zhao wrote: Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier).

Re: [libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-17 Thread Cornelia Huck
On Tue, 10 Jul 2018 16:02:14 +0800 Yi Min Zhao wrote: > Abstract > > The PCI representation in QEMU has recently been extended for S390 > allowing configuration of zPCI attributes like uid (user-defined > identifier) and fid (PCI function identifier). > The details can be found here: >

[libvirt] [PATCH v2 RESEND 00/12] PCI passthrough support on s390

2018-07-10 Thread Yi Min Zhao
Abstract The PCI representation in QEMU has recently been extended for S390 allowing configuration of zPCI attributes like uid (user-defined identifier) and fid (PCI function identifier). The details can be found here: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07262.html