Re: [libvirt] [PATCH v3 9/8] hellolibvirt: Adjust some comments and condition usage

2013-03-04 Thread Eric Blake
On 02/27/2013 05:28 AM, John Ferlan wrote: > On 02/26/2013 07:54 PM, Eric Blake wrote: >> On 02/26/2013 07:20 AM, John Ferlan wrote: >> >> I would have put '---' here, since... >> > > The information was only in the email not part of the git history. > In the future I'll remember to put that afte

Re: [libvirt] [PATCH v3 9/8] hellolibvirt: Adjust some comments and condition usage

2013-02-27 Thread John Ferlan
On 02/26/2013 07:54 PM, Eric Blake wrote: > On 02/26/2013 07:20 AM, John Ferlan wrote: > > I would have put '---' here, since... > The information was only in the email not part of the git history. In the future I'll remember to put that after the '---'. >> examples/hellolibvirt/hellolibvirt.

Re: [libvirt] [PATCH v3 9/8] hellolibvirt: Adjust some comments and condition usage

2013-02-26 Thread Eric Blake
On 02/26/2013 07:20 AM, John Ferlan wrote: I would have put '---' here, since... > v3->v2 difference: Reduced the amount of change to a few comments and > adjusting the (NULL == xxx) and (-1 == xxx) checks > > Since these are just documentation changes - once ACK'd is it OK

[libvirt] [PATCH v3 9/8] hellolibvirt: Adjust some comments and condition usage

2013-02-26 Thread John Ferlan
v3->v2 difference: Reduced the amount of change to a few comments and adjusting the (NULL == xxx) and (-1 == xxx) checks Since these are just documentation changes - once ACK'd is it OK to push now or should I wait for after the freeze? Tks, John --- examples/hellolibvi