Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-09-10 Thread Collin Walling
On 9/10/19 11:38 AM, David Hildenbrand wrote: On 10.09.19 17:22, Jiri Denemark wrote: On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: On 8/20/19 10:06 AM, Jiri Denemark wrote: First, let me apologize for such a late review. I'll try my best to review your series earlier next

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-09-10 Thread David Hildenbrand
On 10.09.19 17:22, Jiri Denemark wrote: > On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: >> On 8/20/19 10:06 AM, Jiri Denemark wrote: >>> First, let me apologize for such a late review. I'll try my best to >>> review your series earlier next time. >>> >> >> Your review is greatly

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-09-10 Thread Jiri Denemark
On Tue, Sep 03, 2019 at 15:32:34 -0400, Collin Walling wrote: > On 8/20/19 10:06 AM, Jiri Denemark wrote: > > First, let me apologize for such a late review. I'll try my best to > > review your series earlier next time. > > > > Your review is greatly appreciated! I haven't replied to your other

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-09-03 Thread Collin Walling
On 8/20/19 10:06 AM, Jiri Denemark wrote: > First, let me apologize for such a late review. I'll try my best to > review your series earlier next time. > Your review is greatly appreciated! I haven't replied to your other posts on this series as my comments were mostly acknowledgements rather

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-08-20 Thread Jiri Denemark
First, let me apologize for such a late review. I'll try my best to review your series earlier next time. On Wed, Jul 17, 2019 at 10:03:21 -0400, Collin Walling wrote: > When baselining CPU models and the user appends the --features argument > to the command, s390x will only report back features

[libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

2019-07-17 Thread Collin Walling
Changelog: v3 - rebased on master v2 - numerous cleanups - removed "policy fix function" and now properly check for policy == -1 in the CPUDef -> JSON parser - resolved some memory leaks - added string arg to