Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-30 Thread Daniel P . Berrangé
On Fri, Apr 26, 2019 at 11:07:49AM +0200, Michal Privoznik wrote: > On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: > > Ports allocated on virtual networks with type=nat|route|open all get > > given an actual type of 'network'. > > > > Only ports in networks with type=bridge use an actual type of

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-29 Thread Laine Stump
On 4/28/19 4:11 PM, Laine Stump wrote: On 4/26/19 5:07 AM, Michal Privoznik wrote: On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-28 Thread Laine Stump
On 4/26/19 5:07 AM, Michal Privoznik wrote: On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type of 'bridge'. This distinction makes

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-26 Thread Michal Privoznik
On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type of 'bridge'. This distinction makes little sense since the virtualization drivers

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-23 Thread Laine Stump
On 4/17/19 1:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type of 'bridge'. This distinction makes little sense since the virtualization drivers

[libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-17 Thread Daniel P . Berrangé
Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type of 'bridge'. This distinction makes little sense since the virtualization drivers will treat both actual types in exactly the same