Re: [libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-30 Thread Eduardo Habkost
On Fri, Sep 30, 2016 at 10:02:49AM +0200, Paolo Bonzini wrote: > On 29/09/2016 23:14, Eduardo Habkost wrote: > > +/* Return the feature property name for a feature flag bit */ > > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > > +{ > > +/* XSAVE components are

Re: [libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-30 Thread Paolo Bonzini
On 29/09/2016 23:14, Eduardo Habkost wrote: > +/* Return the feature property name for a feature flag bit */ > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > +{ > +/* XSAVE components are automatically enabled by other features, > + * so return the original feature

[libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-29 Thread Eduardo Habkost
Fill the "unavailable-features" field on the x86 implementation of query-cpu-definitions. Cc: Jiri Denemark Cc: libvir-list@redhat.com Signed-off-by: Eduardo Habkost --- Changes v3 -> v4: * Handle missing XSAVE components cleanly, but looking up the