Re: [libvirt] [PATCH v5 03/15] qemu_monitor: use cpu def instead of char for expansion

2019-10-02 Thread Jiri Denemark
On Thu, Sep 19, 2019 at 16:24:54 -0400, Collin Walling wrote: > When expanding a CPU model via query-cpu-model-expansion, any features > that were a part of the original model are discarded. For exmaple, > when expanding modelA with features f1, f2, a full expansion may reveal > feature f3, but

[libvirt] [PATCH v5 03/15] qemu_monitor: use cpu def instead of char for expansion

2019-09-19 Thread Collin Walling
When expanding a CPU model via query-cpu-model-expansion, any features that were a part of the original model are discarded. For exmaple, when expanding modelA with features f1, f2, a full expansion may reveal feature f3, but the expanded model will not include f1 or f2. Let's pass a virCPUDefPtr