Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-13 Thread Erik Skultety
On Mon, Apr 02, 2018 at 07:04:25PM -0400, John Ferlan wrote: > > > On 04/02/2018 10:18 AM, Brijesh Singh wrote: > > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted > > VMs on AMD platform using SEV feature. The various inputs required to > > launch SEV guest is provided

Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-05 Thread Brijesh Singh
On 04/04/2018 09:22 AM, John Ferlan wrote: I understand - your other option is to make required. This is one of those cases where there is a gray area with respect to libvirt picking some default or policy that we generally prefer to avoid. I think now I am more inclined towards making it

Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-04 Thread John Ferlan
[...] >>> +VIR_DEBUG("policy=0x%x cbitpos=%d reduced_phys_bits=%d", >>> + sev->policy, sev->cbitpos, sev->reduced_phys_bits); >>> + >>> +virBufferAsprintf(, "sev-guest,id=sev0,cbitpos=%d", sev->cbitpos); >>> +virBufferAsprintf(, ",reduced-phys-bits=%d", >>>

Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-04 Thread Brijesh Singh
On 4/2/18 6:04 PM, John Ferlan wrote: > > On 04/02/2018 10:18 AM, Brijesh Singh wrote: >> QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted >> VMs on AMD platform using SEV feature. The various inputs required to >> launch SEV guest is provided through the tag. A

Re: [libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-02 Thread John Ferlan
On 04/02/2018 10:18 AM, Brijesh Singh wrote: > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted > VMs on AMD platform using SEV feature. The various inputs required to > launch SEV guest is provided through the tag. A typical > SEV guest launch command line looks like

[libvirt] [PATCH v5 05/10] qemu: add support to launch SEV guest

2018-04-02 Thread Brijesh Singh
QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted VMs on AMD platform using SEV feature. The various inputs required to launch SEV guest is provided through the tag. A typical SEV guest launch command line looks like this: # $QEMU ...\ -object