Re: [libvirt] [PATCH v5 11/12] qemu: Validate PCI controllers (QEMU capabilities)

On Mon, 2018-03-05 at 16:58 +0100, Andrea Bolognani wrote: > I'm actually fairly confident we could drop that hunk with no ill > effect, because the spapr-pci-host-bridge must have existed even > before we started checking for it, even if it might possibly have > been, at some point, not

Re: [libvirt] [PATCH v5 11/12] qemu: Validate PCI controllers (QEMU capabilities)

On Fri, 2018-03-02 at 18:44 -0500, Laine Stump wrote: [...] > > +static int > > +virDomainControllerPCIModelNameToQEMUCaps(int modelName) > > +{ > > +switch ((virDomainControllerPCIModelName) modelName) { > > +case VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PCI_BRIDGE: > > +return

Re: [libvirt] [PATCH v5 11/12] qemu: Validate PCI controllers (QEMU capabilities)

On 03/02/2018 10:13 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 190 > - > 1 file changed, 77 insertions(+), 113 deletions(-) > > diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v5 11/12] qemu: Validate PCI controllers (QEMU capabilities)

Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 190 - 1 file changed, 77 insertions(+), 113 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f54e7b87ae..e0ab43e139 100644 ---