Re: [libvirt] [PATCH v5 12/12] qemu: Remove old qemuDomainDeviceDefValidateControllerPCI()

[Laine Stump]

On 03/02/2018 10:13 AM, Andrea Bolognani wrote:
> We've implemented all existing checks, and more, in the new
> function, so we can finally drop the old one.
>
> Signed-off-by: Andrea Bolognani 

Reviewed-by: Laine Stump 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v5 12/12] qemu: Remove old qemuDomainDeviceDefValidateControllerPCI()

[Andrea Bolognani]

We've implemented all existing checks, and more, in the new
function, so we can finally drop the old one.

Signed-off-by: Andrea Bolognani 
---
 src/qemu/qemu_domain.c | 21 +
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e0ab43e139..735341ae16 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4267,25 +4267,6 @@ qemuDomainDeviceDefValidateControllerSCSI(const 
virDomainControllerDef *controll
 }
 
 
-static int
-qemuDomainDeviceDefValidateControllerPCIOld(const virDomainControllerDef 
*controller,
-const virDomainDef *def,
-virQEMUCapsPtr qemuCaps 
ATTRIBUTE_UNUSED)
-{
-/* skip pcie-root */
-if (controller->model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT)
-return 0;
-
-/* Skip pci-root, except for pSeries guests (which actually
- * support more than one PCI Host Bridge per guest) */
-if (!qemuDomainIsPSeries(def) &&
-controller->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT)
-return 0;
-
-return 0;
-}
-
-
 /**
  * virDomainControllerPCIModelNameToQEMUCaps:
  * @modelName: model name
@@ -4823,7 +4804,7 @@ qemuDomainDeviceDefValidateControllerPCI(const 
virDomainControllerDef *cont,
 }
 
  done:
-return qemuDomainDeviceDefValidateControllerPCIOld(cont, def, qemuCaps);
+return 0;
 }
 
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list