Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-15 Thread John Ferlan
On 10/15/2016 09:37 AM, Pavel Hrdina wrote: > On Fri, Oct 14, 2016 at 03:49:13PM -0400, John Ferlan wrote: >> >> >> On 10/14/2016 11:30 AM, Pavel Hrdina wrote: >>> On Fri, Oct 14, 2016 at 10:58:12AM -0400, John Ferlan wrote: [...] >> >> UGH... mea culpa - in my mind the TLS hadn't be

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-15 Thread Pavel Hrdina
On Fri, Oct 14, 2016 at 03:49:13PM -0400, John Ferlan wrote: > > > On 10/14/2016 11:30 AM, Pavel Hrdina wrote: > > On Fri, Oct 14, 2016 at 10:58:12AM -0400, John Ferlan wrote: > >> [...] > > UGH... mea culpa - in my mind the TLS hadn't been added to the chardev > yet and that was t

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread John Ferlan
On 10/14/2016 11:30 AM, Pavel Hrdina wrote: > On Fri, Oct 14, 2016 at 10:58:12AM -0400, John Ferlan wrote: >> [...] UGH... mea culpa - in my mind the TLS hadn't been added to the chardev yet and that was the rest of this series... Of course the rest of this series is adding t

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread Pavel Hrdina
On Fri, Oct 14, 2016 at 10:58:12AM -0400, John Ferlan wrote: > [...] > >> > >> UGH... mea culpa - in my mind the TLS hadn't been added to the chardev > >> yet and that was the rest of this series... Of course the rest of this > >> series is adding the passphrase for the environment (). > >> > >> I

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread John Ferlan
[...] >> >> UGH... mea culpa - in my mind the TLS hadn't been added to the chardev >> yet and that was the rest of this series... Of course the rest of this >> series is adding the passphrase for the environment (). >> >> If I could have got that review earlier, then this situation wouldn't be >>

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread Pavel Hrdina
On Fri, Oct 14, 2016 at 10:16:19AM -0400, John Ferlan wrote: > > > On 10/14/2016 09:49 AM, Pavel Hrdina wrote: > > On Fri, Oct 14, 2016 at 09:32:45AM -0400, John Ferlan wrote: > >> > >> > >> On 10/14/2016 09:18 AM, Pavel Hrdina wrote: > >>> On Fri, Oct 07, 2016 at 07:00:26AM -0400, John Ferlan wr

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread John Ferlan
On 10/14/2016 09:49 AM, Pavel Hrdina wrote: > On Fri, Oct 14, 2016 at 09:32:45AM -0400, John Ferlan wrote: >> >> >> On 10/14/2016 09:18 AM, Pavel Hrdina wrote: >>> On Fri, Oct 07, 2016 at 07:00:26AM -0400, John Ferlan wrote: Add an optional "tls='yes'" option for a TCP chardev for the e

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread Pavel Hrdina
On Fri, Oct 14, 2016 at 09:32:45AM -0400, John Ferlan wrote: > > > On 10/14/2016 09:18 AM, Pavel Hrdina wrote: > > On Fri, Oct 07, 2016 at 07:00:26AM -0400, John Ferlan wrote: > >> Add an optional "tls='yes'" option for a TCP chardev for the > >> express purpose to enable setting up TLS for the c

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread John Ferlan
On 10/14/2016 09:18 AM, Pavel Hrdina wrote: > On Fri, Oct 07, 2016 at 07:00:26AM -0400, John Ferlan wrote: >> Add an optional "tls='yes'" option for a TCP chardev for the >> express purpose to enable setting up TLS for the chardev. This >> will assume that the qemu.conf settings have been adjuste

Re: [libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-14 Thread Pavel Hrdina
On Fri, Oct 07, 2016 at 07:00:26AM -0400, John Ferlan wrote: > Add an optional "tls='yes'" option for a TCP chardev for the > express purpose to enable setting up TLS for the chardev. This > will assume that the qemu.conf settings have been adjusted as > well as the environment configured properly.

[libvirt] [PATCH v8 1/5] domain: Add optional 'tls' attribute for TCP chardev

2016-10-07 Thread John Ferlan
Add an optional "tls='yes'" option for a TCP chardev for the express purpose to enable setting up TLS for the chardev. This will assume that the qemu.conf settings have been adjusted as well as the environment configured properly. Signed-off-by: John Ferlan --- docs/formatdomain.html.in