Re: [libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

2019-05-10 Thread Andrea Bolognani
On Thu, 2019-05-09 at 11:40 -0600, Jim Fehlig wrote: > On 5/9/19 9:18 AM, Andrea Bolognani wrote: > > On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote: > > > +dnl SUSE SLE 12 and OpenSUSE Leap 42.3 still use 2.0.1 > > > > "SUSE SLE" was never a thing, so either > > > >s/SUSE SLE/SUSE Li

Re: [libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

2019-05-09 Thread Jim Fehlig
On 5/9/19 9:18 AM, Andrea Bolognani wrote: On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote: Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did not consider SLE 12 which still has 2.0.1 that does not ship "SLE" is no longer a thing, so either s/SLE/SUSE Linux Enterpris

Re: [libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

2019-05-09 Thread Andrea Bolognani
On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote: > Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did > not consider SLE 12 which still has 2.0.1 that does not ship "SLE" is no longer a thing, so either s/SLE/SUSE Linux Enterprise Server/ (preferred) or s/SLE/SLES/ [.

[libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

2019-05-09 Thread Ján Tomko
Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did not consider SLE 12 which still has 2.0.1 that does not ship a pkg-config file. Similar to how we check for readline, prefer pkg-config if available and fall back to the old detection code if not found. NB: this is not a clean