Re: [libvirt] [PATCHv2 1/10] nwfilter: make ignoring non-zero status easier to follow

2014-02-26 Thread Laine Stump
On 02/26/2014 01:37 AM, Eric Blake wrote: While auditing all callers of virCommandRun, I noticed that nwfilter code never paid attention to commands with a non-zero status; they were merely passing a pointer to avoid spamming the logs with a message about commands that might indeed fail. But

[libvirt] [PATCHv2 1/10] nwfilter: make ignoring non-zero status easier to follow

2014-02-25 Thread Eric Blake
While auditing all callers of virCommandRun, I noticed that nwfilter code never paid attention to commands with a non-zero status; they were merely passing a pointer to avoid spamming the logs with a message about commands that might indeed fail. But proving this required chasing through a lot of