Re: [libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-16 Thread Cedric Bosdonnat
Hi Laine, On Thu, 2015-01-15 at 13:34 -0500, Laine Stump wrote: (Gene - I Cc'ed you because of one question I have for you down in the bowels of the review. Just search for Gene and you'll get to it). Looks like you forgot to actually add Gene to CC ;) On 01/15/2015 04:25 AM, Cédric

Re: [libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-16 Thread Laine Stump
On 01/16/2015 02:45 AM, Cedric Bosdonnat wrote: Hi Laine, On Thu, 2015-01-15 at 13:34 -0500, Laine Stump wrote: (Gene - I Cc'ed you because of one question I have for you down in the bowels of the review. Just search for Gene and you'll get to it). Looks like you forgot to actually add Gene

Re: [libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-15 Thread Laine Stump
(Gene - I Cc'ed you because of one question I have for you down in the bowels of the review. Just search for Gene and you'll get to it). On 01/15/2015 04:25 AM, Cédric Bosdonnat wrote: Moving code for parsing and formatting network routes to networkcommon_conf helps reusing those routes for

Re: [libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-15 Thread Michal Privoznik
On 15.01.2015 10:25, Cédric Bosdonnat wrote: Moving code for parsing and formatting network routes to networkcommon_conf helps reusing those routes for domains. The route definition has been hidden to help reducing the number of unnecessary checks in the format function. --- po/POTFILES.in

[libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-15 Thread Cédric Bosdonnat
Moving code for parsing and formatting network routes to networkcommon_conf helps reusing those routes for domains. The route definition has been hidden to help reducing the number of unnecessary checks in the format function. --- po/POTFILES.in| 1 + src/Makefile.am

Re: [libvirt] [PATCHv2 3/7] Move code related to network routes to networkcommon_conf.[ch]

2015-01-15 Thread Cedric Bosdonnat
On Thu, 2015-01-15 at 11:58 +0100, Michal Privoznik wrote: On 15.01.2015 10:25, Cédric Bosdonnat wrote: Moving code for parsing and formatting network routes to networkcommon_conf helps reusing those routes for domains. The route definition has been hidden to help reducing the number of