Re: [libvirt] [PATCHv2 5/6] util: use new virTypedParameter helpers

2012-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2012 at 11:44:45AM -0700, Eric Blake wrote: Reusing common code makes things smaller; it also buys us some additional safety, such as now rejecting duplicate parameters during a set operation. * src/qemu/qemu_driver.c (qemuDomainSetBlkioParameters)

Re: [libvirt] [PATCHv2 5/6] util: use new virTypedParameter helpers

2012-01-19 Thread Eric Blake
On 01/19/2012 12:21 PM, Daniel P. Berrange wrote: On Thu, Jan 19, 2012 at 11:44:45AM -0700, Eric Blake wrote: Reusing common code makes things smaller; it also buys us some additional safety, such as now rejecting duplicate parameters during a set operation. @@ -2968,42 +2922,25 @@