Re: [libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-29 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 09:30:01PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com This adds per-device weights to blkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the

Re: [libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-15 Thread Eric Blake
On 11/15/2011 12:15 AM, Hu Tao wrote: We can filter out 0-weight here: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b35c83c..5160003 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10893,6 +10893,7 @@ virDomainDefFormatInternal(virDomainDefPtr

[libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-14 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com This adds per-device weights to blkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the domain definition rather than tied to individual devices/disk

Re: [libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-14 Thread Hu Tao
On Mon, Nov 14, 2011 at 09:30:01PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com This adds per-device weights to blkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the