Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-29 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-29 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 03:22:03PM +0800, Hu Tao wrote: On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. ---

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-29 Thread Eric Blake
On 11/14/2011 09:30 PM, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. +if (vm-def-blkio.ndevices) { +if (qemuCgroupControllerActive(driver,

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-29 Thread Eric Blake
On 11/15/2011 12:22 AM, Hu Tao wrote: On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. Does more than the function name says. Would it be

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-29 Thread Eric Blake
On 11/29/2011 10:14 AM, Daniel P. Berrange wrote: Does more than the function name says. Would it be better to just do the parsing here, and set the cgroup values after parsing(see my comment to patch 3 for filtering out 0-weight when writing to xml): Yes, IMHO it is better to do the

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-21 Thread Eric Blake
On 11/15/2011 03:33 PM, Eric Blake wrote: On 11/15/2011 12:22 AM, Hu Tao wrote: On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. +/*

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-15 Thread Eric Blake
On 11/15/2011 12:22 AM, Hu Tao wrote: On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. +/* deviceWeightStr in the form of

[libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-14 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c | 20 ++ src/qemu/qemu_driver.c

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-14 Thread Hu Tao
On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c