Re: [libvirt] [PULL 45/45] numa: Clean up error reporting in parse_numa()

2018-10-23 Thread David Gibson
On Thu, Oct 18, 2018 at 05:04:22PM -0300, Eduardo Habkost wrote: > From: Markus Armbruster > > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_numa() does that, and then fails without setting > an error. Its caller main(), via qemu_opts_foreach(), is

[libvirt] [PULL 45/45] numa: Clean up error reporting in parse_numa()

2018-10-18 Thread Eduardo Habkost
From: Markus Armbruster Calling error_report() in a function that takes an Error ** argument is suspicious. parse_numa() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. While there, give parse_numa()