Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-29 Thread Marcelo Tosatti
On Fri, May 23, 2014 at 11:36:56PM +0200, Paolo Bonzini wrote: You can get the current time via the qom-get command, and then follow the same algorithm as QEMU: time_t seconds; if (rtc_date_offset == -1) { if (rtc_utc) { seconds = mktimegm(tm); } else

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then libvirtd starts again, and doesn't realize the event is lost. Yes,

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Marcelo Tosatti
On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Marcelo Tosatti
On Fri, May 23, 2014 at 10:48:18AM -0300, Marcelo Tosatti wrote: On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Luiz Capitulino
On Fri, 23 May 2014 10:48:18 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Daniel P. Berrange
On Fri, May 23, 2014 at 10:48:18AM -0300, Marcelo Tosatti wrote: On Fri, May 23, 2014 at 03:35:19PM +0200, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Eric Blake
On 05/23/2014 07:48 AM, Marcelo Tosatti wrote: This also seems pretty harmful wrt losing events: /* Global, one-time initializer to configure the rate limiting * and initialize state */ static void monitor_protocol_event_init(void) { /* Limit RTC BALLOON events to 1 per second */

Re: [libvirt] [Qemu-devel] [PATCHv2 3/4] qemu: fix RTC_CHANGE event for clock offset='variable' basis='utc'/

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 15:35, Markus Armbruster ha scritto: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 23 May 2014 00:50:38 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: Then the guest triggers an RTC update, so qemu sends an event, but the event is lost. Then libvirtd starts again,