Re: [libvirt] [RFC] secdrivers remembering original labels

2018-08-06 Thread Daniel P . Berrangé
On Mon, Aug 06, 2018 at 12:01:03PM +0200, Michal Prívozník wrote: > On 08/06/2018 10:30 AM, Daniel P. Berrangé wrote: > > >> > >> So do we really need virtlockd for this? I mean, the whole purpose of it > >> is to hold locks so that libvirtd can restart independently, without > >> losing the lock

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-08-06 Thread Michal Prívozník
On 08/06/2018 10:30 AM, Daniel P. Berrangé wrote: >> >> So do we really need virtlockd for this? I mean, the whole purpose of it >> is to hold locks so that libvirtd can restart independently, without >> losing the lock attached. However, since the metadata lock will be held >> only for a

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-08-06 Thread Daniel P . Berrangé
On Mon, Aug 06, 2018 at 10:02:44AM +0200, Michal Prívozník wrote: > On 07/27/2018 11:01 AM, Daniel P. Berrangé wrote: > > On Fri, Jul 27, 2018 at 09:56:23AM +0200, Michal Privoznik wrote: > >> Dear list, > >> > >> we have this very old bug [1] that I just keep pushing in front of me. I > >> made

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-08-06 Thread Michal Prívozník
On 07/27/2018 11:01 AM, Daniel P. Berrangé wrote: > On Fri, Jul 27, 2018 at 09:56:23AM +0200, Michal Privoznik wrote: >> Dear list, >> >> we have this very old bug [1] that I just keep pushing in front of me. I >> made several attempts to fix it. However, none of them made into the >> tree. I

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-07-27 Thread Daniel P . Berrangé
On Fri, Jul 27, 2018 at 01:27:40PM +0200, Michal Privoznik wrote: > On 07/27/2018 11:01 AM, Daniel P. Berrangé wrote: > > On Fri, Jul 27, 2018 at 09:56:23AM +0200, Michal Privoznik wrote: > >> Dear list, > >> > >> we have this very old bug [1] that I just keep pushing in front of me. I > >> made

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-07-27 Thread Michal Privoznik
On 07/27/2018 11:01 AM, Daniel P. Berrangé wrote: > On Fri, Jul 27, 2018 at 09:56:23AM +0200, Michal Privoznik wrote: >> Dear list, >> >> we have this very old bug [1] that I just keep pushing in front of me. I >> made several attempts to fix it. However, none of them made into the >> tree. I

Re: [libvirt] [RFC] secdrivers remembering original labels

2018-07-27 Thread Daniel P . Berrangé
On Fri, Jul 27, 2018 at 09:56:23AM +0200, Michal Privoznik wrote: > Dear list, > > we have this very old bug [1] that I just keep pushing in front of me. I > made several attempts to fix it. However, none of them made into the > tree. I guess it's time to have discussion what to do about it.

[libvirt] [RFC] secdrivers remembering original labels

2018-07-27 Thread Michal Privoznik
Dear list, we have this very old bug [1] that I just keep pushing in front of me. I made several attempts to fix it. However, none of them made into the tree. I guess it's time to have discussion what to do about it. IIRC, the algorithm that I implemented last was to keep original label in XATTRs