Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Peter Krempa
On Thu, May 12, 2016 at 15:20:51 +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 13:04:23 +0200 > Peter Krempa wrote: > > > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > > I don't think we should do that, unless users already had time to > > > update

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Igor Mammedov
On Thu, 12 May 2016 13:04:23 +0200 Peter Krempa wrote: > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > I don't think we should do that, unless users already had time to > > update their scripts and libvirt had time to implement code > > supporting the new

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Peter Krempa
On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > I don't think we should do that, unless users already had time to > update their scripts and libvirt had time to implement code > supporting the new method. > > I believe libvirt (and people's scripts) use maxcpus only when > they

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Eduardo Habkost
On Thu, May 12, 2016 at 12:29:55PM +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 10:07:03 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, May 11, 2016 at 08:28:59PM -0300, Eduardo Habkost wrote: > > > On Thu, May 12, 2016 at 12:51:55AM +0300, Michael S. Tsirkin wrote: >

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Igor Mammedov
On Thu, 12 May 2016 10:05:54 +0300 "Michael S. Tsirkin" wrote: > On Wed, May 11, 2016 at 08:36:00PM -0300, Eduardo Habkost wrote: > > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > > On Tue, 10 May 2016 17:24:14 -0300 > > > Eduardo Habkost

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-12 Thread Michael S. Tsirkin
On Wed, May 11, 2016 at 08:36:00PM -0300, Eduardo Habkost wrote: > On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > > On Tue, 10 May 2016 17:24:14 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > >

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

2016-05-11 Thread Eduardo Habkost
On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > On Tue, 10 May 2016 17:24:14 -0300 > Eduardo Habkost wrote: > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > > on old machine types CPU hotplug was uncondtionally > > > enabled since it