Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-30 Thread Peter Krempa
On Mon, Apr 30, 2018 at 10:08:05 +0100, Daniel Berrange wrote: > On Mon, Apr 30, 2018 at 10:42:24AM +0200, Peter Krempa wrote: > > On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote: > > > On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > > > > Since libvirt is currently

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-30 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 10:42:24AM +0200, Peter Krempa wrote: > On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote: > > On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > > > Since libvirt is currently not able to setup the NBD migration stream > > > secured by TLS we

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-30 Thread Peter Krempa
On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote: > On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > > Since libvirt is currently not able to setup the NBD migration stream > > secured by TLS we should not allow such migration since data would be > > transferred

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-27 Thread Daniel P . Berrangé
On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > Since libvirt is currently not able to setup the NBD migration stream > secured by TLS we should not allow such migration since data would be > transferred unencrypted. > > This will break compatibility of TLS migration if non-shared

Re: [libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-27 Thread Kashyap Chamarthy
On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote: > Since libvirt is currently not able to setup the NBD migration stream > secured by TLS we should not allow such migration since data would be > transferred unencrypted. > > This will break compatibility of TLS migration if non-shared

[libvirt] [RFC PATCH 4/4] qemu: migration: Forbid 'nbd' migration of non-shared storage if TLS is requested

2018-04-26 Thread Peter Krempa
Since libvirt is currently not able to setup the NBD migration stream secured by TLS we should not allow such migration since data would be transferred unencrypted. This will break compatibility of TLS migration if non-shared storage is requested but the security implications are more severe.