Re: [libvirt] [RFC PATCH 5/6] conf: Parse and format HPT maxpagesize

2018-05-23 Thread Peter Krempa
On Wed, May 23, 2018 at 18:52:57 +0200, Andrea Bolognani wrote: > On Wed, 2018-05-23 at 18:36 +0200, Peter Krempa wrote: > > On Wed, May 23, 2018 at 18:18:01 +0200, Andrea Bolognani wrote: > > > +def->hpt_maxpagesize = VIR_ROUND_UP(def->hpt_maxpagesize, > > > 1024); > > > > The code

Re: [libvirt] [RFC PATCH 5/6] conf: Parse and format HPT maxpagesize

2018-05-23 Thread Andrea Bolognani
On Wed, 2018-05-23 at 18:36 +0200, Peter Krempa wrote: > On Wed, May 23, 2018 at 18:18:01 +0200, Andrea Bolognani wrote: > > +def->hpt_maxpagesize = VIR_ROUND_UP(def->hpt_maxpagesize, > > 1024); > > The code in the patch using it with qemu actually expects so this is a > power of 2,

Re: [libvirt] [RFC PATCH 5/6] conf: Parse and format HPT maxpagesize

2018-05-23 Thread Peter Krempa
On Wed, May 23, 2018 at 18:18:01 +0200, Andrea Bolognani wrote: > This commit is best viewed with 'git show -w'. > > Signed-off-by: Andrea Bolognani > --- > docs/schemas/domaincommon.rng | 21 ++--- > src/conf/domain_conf.c| 44

[libvirt] [RFC PATCH 5/6] conf: Parse and format HPT maxpagesize

2018-05-23 Thread Andrea Bolognani
This commit is best viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 21 ++--- src/conf/domain_conf.c| 44 --- src/conf/domain_conf.h| 1 +