Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Fabiano Fidêncio
On Mon, Sep 23, 2019 at 12:38 PM Pavel Hrdina wrote: > > On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > > > For what it's worth, I also

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > > For what it's worth, I also prefer 'syntax': the -check suffix is > > > useful for make

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > For what it's worth, I also prefer 'syntax': the -check suffix is > > useful for make because it highlights that you're verifying some > > property of the program,

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 10:17 +0200, Pavel Hrdina wrote: > > On Sat, Sep 21, 2019 at 09:22:38AM +0200, Fabiano Fidêncio wrote: > > > One last things here (thanks, Pavel, for pointing this out), I'd > > > prefer the 'syntax' suite

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 10:17 +0200, Pavel Hrdina wrote: > On Sat, Sep 21, 2019 at 09:22:38AM +0200, Fabiano Fidêncio wrote: > > One last things here (thanks, Pavel, for pointing this out), I'd > > prefer the 'syntax' suite being called 'syntax-check' just because > > people are already used to the

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 10:07:59AM +0200, Ján Tomko wrote: > On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote: > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly new

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Pavel Hrdina
On Sat, Sep 21, 2019 at 09:22:38AM +0200, Fabiano Fidêncio wrote: > On Fri, Sep 20, 2019 at 2:34 PM Fabiano Fidêncio wrote: > > > > [snip] > > > > > > > > > In general, it looks good and works as expected. > > > > I will add my "Reviewed-by: " after we discuss the points raised. > > > > > > > >

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Ján Tomko
On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote: Meson build system is simple and quick compared to Autotools and it's able to fully replace our Autotools usage. There are few drawbacks as it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, it's still evolving

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-21 Thread Fabiano Fidêncio
On Fri, Sep 20, 2019 at 2:34 PM Fabiano Fidêncio wrote: > > [snip] > > > > > > In general, it looks good and works as expected. > > > I will add my "Reviewed-by: " after we discuss the points raised. > > > > > > Another thing, please, let's sync to have the libvirt-jenkins-ci work > > > done and

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Fabiano Fidêncio
[snip] > > > In general, it looks good and works as expected. > > I will add my "Reviewed-by: " after we discuss the points raised. > > > > Another thing, please, let's sync to have the libvirt-jenkins-ci work > > done and merged before this one gets merged. > > Works for me, thanks for review,

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Pavel Hrdina
On Fri, Sep 20, 2019 at 01:28:28PM +0200, Fabiano Fidêncio wrote: > On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote: > > > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly new

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Fabiano Fidêncio
On Fri, Sep 20, 2019 at 1:28 PM Fabiano Fidêncio wrote: > > On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote: > > > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly new build

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Fabiano Fidêncio
On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote: > > Meson build system is simple and quick compared to Autotools and it's > able to fully replace our Autotools usage. There are few drawbacks as > it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, > it's still evolving

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Daniel P . Berrangé
On Fri, Sep 20, 2019 at 11:36:53AM +0200, Pavel Hrdina wrote: > On Fri, Sep 20, 2019 at 10:14:00AM +0100, Daniel P. Berrangé wrote: > > On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote: > > > Meson build system is simple and quick compared to Autotools and it's > > > able to fully

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Pavel Hrdina
On Fri, Sep 20, 2019 at 10:14:00AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote: > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Daniel P . Berrangé
On Fri, Sep 20, 2019 at 11:03:42AM +0200, Pavel Hrdina wrote: > Meson build system is simple and quick compared to Autotools and it's > able to fully replace our Autotools usage. There are few drawbacks as > it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, > it's still

[libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-20 Thread Pavel Hrdina
Meson build system is simple and quick compared to Autotools and it's able to fully replace our Autotools usage. There are few drawbacks as it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, it's still evolving and the user base is not that large and there were some tweaks