Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 04:21:19PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 15:02 +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 17, 2018 at 03:57:04PM +0200, Andrea Bolognani wrote: > > > We could go one further and use > > > > > > name: '{name}-{branch}-build{variant}' > > >

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 15:02 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 17, 2018 at 03:57:04PM +0200, Andrea Bolognani wrote: > > We could go one further and use > > > > name: '{name}-{branch}-build{variant}' > > > > for the generic-build-job template and > > > > variant: +website > > >

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 03:57:04PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 14:33 +0100, Daniel P. Berrangé wrote: > > Instead just change the templates from doing > > > > name: '{name}-{branch}-build' > > > > to > > > > name: '{name}-{branch}-build{jobsuffix}' > > > >

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 14:33 +0100, Daniel P. Berrangé wrote: > Instead just change the templates from doing > > name: '{name}-{branch}-build' > > to > > name: '{name}-{branch}-build{jobsuffix}' > > Then the website job can just set > >jobsuffix: website > > and everything else

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 03:28:38PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 14:11 +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 17, 2018 at 02:52:08PM +0200, Andrea Bolognani wrote: > > > Are you sure? It seems to me like the problem stems from the fact > > > that we have both > >

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 14:11 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 17, 2018 at 02:52:08PM +0200, Andrea Bolognani wrote: > > Are you sure? It seems to me like the problem stems from the fact > > that we have both > > > > - job-template: > > id: autotools-build-job > > name:

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 02:52:08PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 13:08 +0100, Daniel P. Berrangé wrote: > > Hmm, this is a problem with us repurposing 'name' as a parameter > > for the template, when it is also a declared field. > > > > eg the core issue is this: > > > >

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 13:08 +0100, Daniel P. Berrangé wrote: > Hmm, this is a problem with us repurposing 'name' as a parameter > for the template, when it is also a declared field. > > eg the core issue is this: > > name: '{name}-{branch}-build' > > We should address this by changing the

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 12:41:09PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 11:19 +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 17, 2018 at 12:13:01PM +0200, Andrea Bolognani wrote: > > > Do you want me to send v2, or can I just squash this in and push? > > > > Fine to squash it

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 11:19 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 17, 2018 at 12:13:01PM +0200, Andrea Bolognani wrote: > > Do you want me to send v2, or can I just squash this in and push? > > Fine to squash it unless you notice something complicated needs > furtehr changing. Hm,

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, Apr 17, 2018 at 12:13:01PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-17 at 10:54 +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 12, 2018 at 05:59:28PM +0200, Andrea Bolognani wrote: > > > diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml > > > index 13f39f9..427cf6a

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Tue, 2018-04-17 at 10:54 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 12, 2018 at 05:59:28PM +0200, Andrea Bolognani wrote: > > diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml > > index 13f39f9..427cf6a 100644 > > --- a/projects/libvirt.yaml > > +++ b/projects/libvirt.yaml > > @@

Re: [libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

On Thu, Apr 12, 2018 at 05:59:28PM +0200, Andrea Bolognani wrote: > This will ensure libvirt maintains the minimum amount of > compatibility with CentOS 6 that running its website on that > platform requires. > > Signed-off-by: Andrea Bolognani > --- >

[libvirt] [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

This will ensure libvirt maintains the minimum amount of compatibility with CentOS 6 that running its website on that platform requires. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-6/main.yml | 1 + projects/libvirt.yaml | 4