Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-15 Thread Daniel P . Berrangé
On Wed, Aug 15, 2018 at 06:08:18PM +0200, Andrea Bolognani wrote: > On Fri, 2018-08-10 at 10:38 +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > > G_ADD_PRIVATE was added in 2.38 and older functions are getting > > > deprecated: > > >

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-15 Thread Andrea Bolognani
On Fri, 2018-08-10 at 10:38 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min glib2

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 10:38:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 01:16:20PM +0200, Michal Privoznik wrote: > On 08/10/2018 01:03 PM, Michal Privoznik wrote: > > On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: > >> On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > >>> G_ADD_PRIVATE was added in 2.38 and older functions

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Michal Privoznik
On 08/10/2018 01:03 PM, Michal Privoznik wrote: > On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: >> On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: >>> G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: >>>

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Michal Privoznik
On 08/10/2018 11:38 AM, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: >> G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: >> https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min glib2 version is

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 10:38:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min

Re: [libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Our min glib2 version is currently 2.36, since that's what RHEL-7 has. So this change

[libvirt] [libvirt-glib][PATCH] Use new GObject define macros with private

2018-08-10 Thread Michal Privoznik
G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits Signed-off-by: Michal Privoznik --- This was generated mostly using: sed -i "s/G_DEFINE_TYPE(/G_DEFINE_TYPE_WITH_PRIVATE(/ sed -i