Re: [libvirt] [libvirt-glib] All string getters should return 'const'

2012-03-12 Thread Christophe Fergeau
On Wed, Mar 07, 2012 at 06:02:06AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org There is no need for all the memory (de)allocations and especially forcing the app developers to free the strings. They can always g_strdup() the returned string if they

Re: [libvirt] [libvirt-glib] All string getters should return 'const'

2012-03-08 Thread Christophe Fergeau
Hey, Thanks for doing this! I'll do a more in depth review on Monday if noone beats me to it, just some quick notes: On Wed, Mar 07, 2012 at 06:02:06AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org -char * -gvir_config_xml_get_child_element_content_glib

[libvirt] [libvirt-glib] All string getters should return 'const'

2012-03-06 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org There is no need for all the memory (de)allocations and especially forcing the app developers to free the strings. They can always g_strdup() the returned string if they need. --- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 13 ++---