Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-08 Thread Christophe Fergeau
On Wed, Mar 07, 2012 at 01:56:44AM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Mar 7, 2012 at 1:03 AM, Eric Blake ebl...@redhat.com wrote: Actually, if I understand things right, preserving order _is_ important to guarantee.  For example, with older XML that lacked per-device boot

Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-07 Thread Daniel P. Berrange
On Wed, Mar 07, 2012 at 12:27:53AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to keep them sorted the same way we get them from

[libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to keep them sorted the same way we get them from configuration (XML). --- libvirt-gobject/libvirt-gobject-domain.c |2 +- 1

Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Eric Blake
On 03/06/2012 03:27 PM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to keep them sorted the same way we get them from configuration (XML).

Re: [libvirt] [libvirt-glib] Keep domain devices list sorted

2012-03-06 Thread Zeeshan Ali (Khattak)
On Wed, Mar 7, 2012 at 1:03 AM, Eric Blake ebl...@redhat.com wrote: On 03/06/2012 03:27 PM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org While we don't guarantee the order of devices in the list returned from gvir_domain_get_devices(), its not a bad idea to