Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
Hey, On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote: On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Ping for this patch and for 3/3 ? ./test-domain-create gives: channel type=spicevmc target type=channel-target-virtio/

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Marc-André Lureau
On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case, just to be sure. -- Marc-André Lureau -- libvir-list mailing list

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case,

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 04:15:59PM +0100, Christophe Fergeau wrote: Hey, On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote: On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Ping for this patch and for 3/3 ? ./test-domain-create gives:

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 04:31:56PM +0100, Christophe Fergeau wrote: On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case,

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Marc-André Lureau
So it looks ok to me, but On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote: I tend to only add API in libvirt-gconfig when there's a need for it, but I can look into adding API to set the address element if you think that's needed now. How do you verify

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote: How do you verify new_from_xml()? Am I missing something? This is just copy and paste, and keeping all files consistent. I don't think we have any user of these methods, except the top level ones, and I'm not sure it's really

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 06:37:04PM +0100, Christophe Fergeau wrote: On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote: How do you verify new_from_xml()? Am I missing something? This is just copy and paste, and keeping all files consistent. I don't think we have any user of

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-12 Thread Christophe Fergeau
Ping for this patch and for 3/3 ? Christophe On Tue, Mar 06, 2012 at 05:38:33PM +0100, Christophe Fergeau wrote: This is needed to be able to add the SPICE agent channels --- libvirt-gconfig/Makefile.am|2 + ...ibvirt-gconfig-domain-chardev-source-spicevmc.c |

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-12 Thread Marc-André Lureau
On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Ping for this patch and for 3/3 ? ./test-domain-create gives: channel type=spicevmc target type=channel-target-virtio/ /channel Where we expect this: channel type='spicevmc' target

[libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-06 Thread Christophe Fergeau
This is needed to be able to add the SPICE agent channels --- libvirt-gconfig/Makefile.am|2 + ...ibvirt-gconfig-domain-chardev-source-spicevmc.c | 80 ...ibvirt-gconfig-domain-chardev-source-spicevmc.h | 70 +