Re: [libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart

2017-06-06 Thread Michal Privoznik
On 06/05/2017 09:57 PM, Dawid Zamirski wrote: > Aside from that: > * fix arginfo_libvirt_conn_flags - it has 2 args not 1 > * get rid arginfo_libvirt_domain_set_autostart and use > arginfo_libvirt_conn_flags instead as it's the same. > --- > src/libvirt-php.c | 54

Re: [libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart

2017-06-06 Thread Vasiliy Tolstov
2017-06-05 22:57 GMT+03:00 Dawid Zamirski : > Aside from that: > * fix arginfo_libvirt_conn_flags - it has 2 args not 1 > * get rid arginfo_libvirt_domain_set_autostart and use > arginfo_libvirt_conn_flags instead as it's the same. Looks good to me -- Vasiliy Tolstov,

[libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart

2017-06-05 Thread Dawid Zamirski
Aside from that: * fix arginfo_libvirt_conn_flags - it has 2 args not 1 * get rid arginfo_libvirt_domain_set_autostart and use arginfo_libvirt_conn_flags instead as it's the same. --- src/libvirt-php.c | 54 +++--- src/libvirt-php.h | 2 ++ 2