[libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- bin/virt-sandbox-service | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 03873c9..26b4a40 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@

Re: [libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 06:26:46PM +0800, Alex Jia wrote: Please explain the scenario where you hit the flaw in the commit message. I can see what you've changed, but I don't see why you have changed it. The commit message must describe the 'why'. Signed-off-by: Alex Jia a...@redhat.com ---

Re: [libvirt] [libvirt-sandbox][PATCH 1/2] Fix logical judgement in get_name

2013-08-09 Thread Alex Jia
On 08/09/2013 06:29 PM, Daniel P. Berrange wrote: On Fri, Aug 09, 2013 at 06:26:46PM +0800, Alex Jia wrote: Please explain the scenario where you hit the flaw in the commit message. I can see what you've changed, but I don't see why you have changed it. The commit message must describe the