Re: [libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

2012-03-22 Thread Peter Krempa
On 03/21/2012 05:02 PM, Guannan Ren wrote: On 03/21/2012 08:46 PM, Peter Krempa wrote: This patch adds a wrapper that enables work with consoles in the test-API. --- lib/domainAPI.py | 9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py

Re: [libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

2012-03-22 Thread Guannan Ren
Wouldn't this actualy defeat the encapsulation that is provided in the StreamAPI class? With this change you can reuse the StreamAPI object for other actions later on too, without loosing the abstraction. With the chagne you pushed: diff --git a/lib/domainAPI.py b/lib/domainAPI.py index

[libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

2012-03-21 Thread Peter Krempa
This patch adds a wrapper that enables work with consoles in the test-API. --- lib/domainAPI.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 91f2ba3..bc0069b 100644 --- a/lib/domainAPI.py +++ b/lib/domainAPI.py @@

Re: [libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

2012-03-21 Thread Guannan Ren
On 03/21/2012 08:46 PM, Peter Krempa wrote: This patch adds a wrapper that enables work with consoles in the test-API. --- lib/domainAPI.py |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 91f2ba3..bc0069b 100644 ---