Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/26/2012 03:02 PM, Guannan Ren wrote: On 03/25/2012 01:42 AM, Martin Kletzander wrote: I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py |

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Guannan Ren
On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should use native approach to do the checking. So I insist on the original checking. There was no lookupByName function, but I agree it's better

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/27/2012 10:59 AM, Guannan Ren wrote: On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should use native approach to do the checking. So I insist on the original checking. There was no

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Guannan Ren
On 03/27/2012 05:42 PM, Martin Kletzander wrote: On 03/27/2012 10:59 AM, Guannan Ren wrote: On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should use native approach to do the checking. So I

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-27 Thread Martin Kletzander
On 03/27/2012 12:35 PM, Guannan Ren wrote: On 03/27/2012 05:42 PM, Martin Kletzander wrote: On 03/27/2012 10:59 AM, Guannan Ren wrote: On 03/27/2012 03:57 PM, Martin Kletzander wrote: It's better not to use libvirt API to check the result of one another API. We should

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-26 Thread Guannan Ren
On 03/25/2012 01:42 AM, Martin Kletzander wrote: I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py | 132

[libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-24 Thread Martin Kletzander
I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py | 132 utils/Python/utils.py | 45