Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-19 Thread 何鑫
At 2019-08-16 23:10:31, "Laine Stump" wrote: >The fact that you are modifying this code implies that you are using it, >and that implies that you are still using legacy KVM device assignment >(i.e. the pcistub driver) instead of VFIO device assignment. (I say this >because the function that

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-19 Thread Jim Fehlig
On 8/19/19 7:22 AM, Michal Privoznik wrote: > On 8/16/19 5:10 PM, Laine Stump wrote: > > > > To extend this question - there's also xen's pciback, but I don't know enough > about Xen to tell if it's still in use. Yes, it is still in use. > Might be worth dropping that too, > becasue it looks

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-19 Thread Michal Privoznik
On 8/16/19 5:10 PM, Laine Stump wrote: > To extend this question - there's also xen's pciback, but I don't know enough about Xen to tell if it's still in use. Might be worth dropping that too, becasue it looks a lot like pci-stub (used for KVM assignment). And because of that I can't really

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-16 Thread Laine Stump
The fact that you are modifying this code implies that you are using it, and that implies that you are still using legacy KVM device assignment (i.e. the pcistub driver) instead of VFIO device assignment. (I say this because the function that calls this function you've patched,

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-16 Thread Michal Privoznik
On 8/15/19 11:44 AM, hexin900...@163.com wrote: From: hexin The parent bridge configuration of the current device should be read and reset, instead of reading the current device configuration. Signed-off-by: He Xin Signed-off-by: Liu Qi Signed-off-by: Zhang Yu --- src/util/virpci.c | 2

[libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-15 Thread hexin900110
From: hexin The parent bridge configuration of the current device should be read and reset, instead of reading the current device configuration. Signed-off-by: He Xin Signed-off-by: Liu Qi Signed-off-by: Zhang Yu --- src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)