Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-10-16 Thread Marcus Furlong
On Mon, 30 Sep 2019 at 21:05, Bruno Haible wrote: > > Daniel P. Berrangé wrote: > > > For what purpose is libvirt or QEMU using setgroups()? What goes wrong if > > > setgroups() fails? On macOS, as far as I can see, everything works as expected without it. So not sure if it's actually needed? >

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-10-01 Thread Bruno Haible
Daniel P. Berrangé wrote: > > For what purpose is libvirt or QEMU using setgroups()? What goes wrong if > > setgroups() fails? > > QEMU potentially needs access to files owned by a supplementary group. > On Linux for example, /dev/kvm is often owned by 'kvm' group, but the > 'qemu' user on Fedora

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-30 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 02:06:07PM +0200, Bruno Haible wrote: > Daniel P. Berrangé wrote: > > > > FWIW I compiled libvirt without the setgroups code on Mac and it > > > > worked as expected. Not sure what the implications of that are though? > > > > > > OK, then the fix would be to not use setgrou

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-30 Thread Bruno Haible
Daniel P. Berrangé wrote: > > > FWIW I compiled libvirt without the setgroups code on Mac and it > > > worked as expected. Not sure what the implications of that are though? > > > > OK, then the fix would be to not use setgroups on Mac, and nothing to do > > in gnulib. Right? > > Not calling setg

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-30 Thread Daniel P . Berrangé
On Sat, Sep 28, 2019 at 01:36:15PM +0200, Bruno Haible wrote: > Marcus Furlong wrote: > > FWIW I compiled libvirt without the setgroups code on Mac and it > > worked as expected. Not sure what the implications of that are though? > > OK, then the fix would be to not use setgroups on Mac, and nothi

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-28 Thread Bruno Haible
Marcus Furlong wrote: > FWIW I compiled libvirt without the setgroups code on Mac and it > worked as expected. Not sure what the implications of that are though? OK, then the fix would be to not use setgroups on Mac, and nothing to do in gnulib. Right? Bruno -- libvir-list mailing list libvir-li

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-09-27 Thread Marcus Furlong
On Fri, 30 Aug 2019 at 21:33, Bruno Haible wrote: > > Hi Eric, > > > I wonder if gnulib could provide a workaround setgroups() that overcomes > > this issue > > I don't see how a workaround could look like. The problem is not the value > of NGROUPS_MAX in user-space, but the same value NGROUPS_MAX

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-30 Thread Bruno Haible
Hi Eric, > I wonder if gnulib could provide a workaround setgroups() that overcomes > this issue I don't see how a workaround could look like. The problem is not the value of NGROUPS_MAX in user-space, but the same value NGROUPS_MAX in the kernel. More precisely, in the Darwin kernel file bsd/ker

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-30 Thread Eric Blake
[adding gnulib] On 8/21/19 1:34 PM, Roman Bolshakov wrote: > I get the following error when running libvirtd on MacOS as root: > > 2019-07-11 00:12:33.673+: 123145573953536: error : > qemuProcessQMPLaunch:8501 : internal error: Failed to start QEMU > binary /usr/local/bin/

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-30 Thread Daniel P . Berrangé
On Fri, Aug 30, 2019 at 11:42:50AM -0400, Marcus Furlong wrote: > On Thu, 22 Aug 2019 at 05:34, Daniel P. Berrangé wrote: > > > > On Wed, Aug 21, 2019 at 09:34:05PM +0300, Roman Bolshakov wrote: > > > On Wed, Aug 21, 2019 at 05:55:51PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Aug 21, 2019

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-30 Thread Marcus Furlong
On Thu, 22 Aug 2019 at 05:34, Daniel P. Berrangé wrote: > > On Wed, Aug 21, 2019 at 09:34:05PM +0300, Roman Bolshakov wrote: > > On Wed, Aug 21, 2019 at 05:55:51PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 21, 2019 at 12:47:03PM -0400, Marcus Furlong wrote: > > > > On Wed, 21 Aug 2019 at

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-22 Thread Daniel P . Berrangé
On Wed, Aug 21, 2019 at 09:34:05PM +0300, Roman Bolshakov wrote: > On Wed, Aug 21, 2019 at 05:55:51PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 21, 2019 at 12:47:03PM -0400, Marcus Furlong wrote: > > > On Wed, 21 Aug 2019 at 08:23, Daniel P. Berrangé > > > wrote: > > > > > > > > On Tue, Au

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-21 Thread Roman Bolshakov
On Wed, Aug 21, 2019 at 05:55:51PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 21, 2019 at 12:47:03PM -0400, Marcus Furlong wrote: > > On Wed, 21 Aug 2019 at 08:23, Daniel P. Berrangé > > wrote: > > > > > > On Tue, Aug 20, 2019 at 11:11:07AM -0400, Marcus Furlong wrote: > > > > Resend to libvi

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-21 Thread Daniel P . Berrangé
On Wed, Aug 21, 2019 at 12:47:03PM -0400, Marcus Furlong wrote: > On Wed, 21 Aug 2019 at 08:23, Daniel P. Berrangé wrote: > > > > On Tue, Aug 20, 2019 at 11:11:07AM -0400, Marcus Furlong wrote: > > > Resend to libvir-list in case that is more appropriate: > > > > > > > > > Hi, > > > > > > I get th

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-21 Thread Marcus Furlong
On Wed, 21 Aug 2019 at 08:23, Daniel P. Berrangé wrote: > > On Tue, Aug 20, 2019 at 11:11:07AM -0400, Marcus Furlong wrote: > > Resend to libvir-list in case that is more appropriate: > > > > > > Hi, > > > > I get the following error when running libvirtd on MacOS as root: > > > > 2019-07-11 00:12

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-21 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 11:11:07AM -0400, Marcus Furlong wrote: > Resend to libvir-list in case that is more appropriate: > > > Hi, > > I get the following error when running libvirtd on MacOS as root: > > 2019-07-11 00:12:33.673+: 123145573953536: error : > qemuProcessQMPLaunch:8501 : inte

[libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-21 Thread Marcus Furlong
Resend to libvir-list in case that is more appropriate: Hi, I get the following error when running libvirtd on MacOS as root: 2019-07-11 00:12:33.673+: 123145573953536: error : qemuProcessQMPLaunch:8501 : internal error: Failed to start QEMU binary /usr/local/bin/qemu-system-x86_64 for prob