Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Stefan Berger
On 11/14/2011 10:36 PM, Eric Blake wrote: On 11/14/2011 05:54 PM, Stefan Berger wrote: On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 06:34:27AM -0500, Stefan Berger wrote: On 11/14/2011 10:36 PM, Eric Blake wrote: On 11/14/2011 05:54 PM, Stefan Berger wrote: On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64.

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Justin Clift
On 15/11/2011, at 10:34 PM, Stefan Berger wrote: +/* strchr work-around for gcc 4.3 4.4 bug with -Wlogical-op + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513 + */ Cool, that's good investigation Stefan. :) + Justin -- Aeolus Community Manager

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Stefan Berger
On 11/15/2011 06:41 AM, Daniel P. Berrange wrote: On Tue, Nov 15, 2011 at 06:34:27AM -0500, Stefan Berger wrote: Is the difference just that we're deferencing a char * for the second arg rather than using a constant value ? Would it suffice to do int c = *cur; if (strchr(toescape, c)) I

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Eric Blake
On 11/15/2011 04:41 AM, Daniel P. Berrange wrote: while (*cur != 0) { -if (strchr(toescape, *cur)) +/* strchr work-around for gcc 4.3 4.4 bug with -Wlogical-op + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513 + */ +char needle[2] = { *cur, 0

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Eric Blake
On 11/15/2011 04:34 AM, Stefan Berger wrote: What about this here: --- a/src/util/buf.c +++ b/src/util/buf.c @@ -466,7 +466,11 @@ virBufferEscape(virBufferPtr buf, const char *toescape, cur = str; out = escaped; while (*cur != 0) { -if (strchr(toescape, *cur)) +

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Stefan Berger
On 11/11/2011 04:54 PM, Justin Clift wrote: On 12/11/2011, at 8:06 AM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Stefan Berger
On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function 'virBufferEscape': util/buf.c:469: warning:

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-14 Thread Eric Blake
On 11/14/2011 05:54 PM, Stefan Berger wrote: On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-11 Thread Eric Blake
On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function 'virBufferEscape': util/buf.c:469: warning: logical '' with non-zero constant will always

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-11 Thread Justin Clift
On 12/11/2011, at 8:06 AM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-command.o util/buf.c: In function 'virBufferEscape': util/buf.c:469: warning:

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-09 Thread Michal Privoznik
On 09.11.2011 07:46, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: make[3]: Entering directory `/home/jc/git_repos/libvirt/src' CC libvirt_util_la-bitmap.lo CC libvirt_util_la-authhelper.lo CC

[libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-08 Thread Justin Clift
Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: make[3]: Entering directory `/home/jc/git_repos/libvirt/src' CC libvirt_util_la-bitmap.lo CC libvirt_util_la-authhelper.lo CC libvirt_util_la-bridge.lo CC