Re: [libvirt PATCH] qemu: Signal domain condition in qemuProcessStop a bit later

2021-07-19 Thread Jiri Denemark
On Mon, Jul 19, 2021 at 09:37:01 +0200, Michal Prívozník wrote: > On 7/16/21 5:06 PM, Jiri Denemark wrote: > > Signaling the condition before vm->def->id is reset to -1 is dangerous: > > in case a waiting thread wakes up, it does not see anything interesting > > (the domain is still marked as

Re: [libvirt PATCH] qemu: Signal domain condition in qemuProcessStop a bit later

2021-07-19 Thread Michal Prívozník
On 7/16/21 5:06 PM, Jiri Denemark wrote: > Signaling the condition before vm->def->id is reset to -1 is dangerous: > in case a waiting thread wakes up, it does not see anything interesting > (the domain is still marked as running) and just enters virDomainObjWait > where it waits forever because

[libvirt PATCH] qemu: Signal domain condition in qemuProcessStop a bit later

2021-07-16 Thread Jiri Denemark
Signaling the condition before vm->def->id is reset to -1 is dangerous: in case a waiting thread wakes up, it does not see anything interesting (the domain is still marked as running) and just enters virDomainObjWait where it waits forever because the condition will never be signalled again.